fix: use bigint gwei type for amount in requests instead of num 64 (#…

…7085) * fix: use bigint gwei type for amount in requests instead of num 64 * revert deposit amount to uintnum64 as unlikely to get a high amount * fix
ChainSafe · Sep 14, 2024 · 295690b · 295690b
1 parent d6e8c05
commit 295690b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/beacon-node/src/execution/engine/types.ts b/packages/beacon-node/src/execution/engine/types.ts
@@ -461,7 +461,7 @@ export function deserializeWithdrawalRequest(withdrawalRequest: WithdrawalReques
   return {
     sourceAddress: dataToBytes(withdrawalRequest.sourceAddress, 20),
     validatorPubkey: dataToBytes(withdrawalRequest.validatorPubkey, 48),
-    amount: quantityToNum(withdrawalRequest.amount),
+    amount: quantityToBigint(withdrawalRequest.amount),
   };
 }
 

diff --git a/packages/types/src/electra/sszTypes.ts b/packages/types/src/electra/sszTypes.ts
@@ -116,6 +116,8 @@ export const DepositRequest = new ContainerType(
   {
     pubkey: BLSPubkey,
     withdrawalCredentials: Bytes32,
+    // this is actually gwei uintbn64 type, but super unlikely to get a high amount here
+    // to warrant a bn type
     amount: UintNum64,
     signature: BLSSignature,
     index: DepositIndex,
@@ -129,7 +131,7 @@ export const WithdrawalRequest = new ContainerType(
   {
     sourceAddress: ExecutionAddress,
     validatorPubkey: BLSPubkey,
-    amount: UintNum64,
+    amount: Gwei,
   },
   {typeName: "WithdrawalRequest", jsonCase: "eth2"}
 );