chore: review PR

ChainSafe · Sep 16, 2024 · d1d0e22 · d1d0e22
1 parent afc03f2
commit d1d0e22
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/beacon-node/src/chain/shufflingCache.ts b/packages/beacon-node/src/chain/shufflingCache.ts
@@ -185,7 +185,6 @@ export class ShufflingCache implements IShufflingCache {
       const shuffling = computeEpochShuffling(state, activeIndices, epoch);
       timer?.();
       this.set(shuffling, decisionRoot);
-      // wait until after the first slot to help with attestation and block proposal performance
     });
   }
 

diff --git a/packages/state-transition/src/stateTransition.ts b/packages/state-transition/src/stateTransition.ts
@@ -166,6 +166,25 @@ export function processSlots(
 
 /**
  * All processSlot() logic but separate so stateTransition() can recycle the caches
+ *
+ * Epoch transition will be processed at the last slot of an epoch. Note that compute_shuffling() is going
+ * to be executed in parallel (either by napi-rs or worker thread) with processEpoch() like below:
+ *
+ *   state-transition
+ *   ╔══════════════════════════════════════════════════════════════════════════════════╗
+ *   ║   beforeProcessEpoch          processEpoch                 afterPRocessEpoch     ║
+ *   ║  |-------------------------|--------------------|-------------------------------|║
+ *   ║                       |                         |     |                          ║
+ *   ╚═══════════════════════|═══════════════════════════════|══════════════════════════╝
+ *                           |                               |
+ *                         build()                          get()
+ *                           |                               |
+ *   ╔═══════════════════════V═══════════════════════════════V═══════════════════════════╗
+ *   ║                       |                               |                           ║
+ *   ║                       |-------------------------------|                           ║
+ *   ║                          compute_shuffling()                                      ║
+ *   ╚═══════════════════════════════════════════════════════════════════════════════════╝
+ *   beacon-node ShufflingCache
  */
 function processSlotsWithTransientCache(
   postState: CachedBeaconStateAllForks,