Add Apple M1 support to lodestar #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit e06cd73 and detected 0 issues on this pull request. View more on Code Climate. |
wemeetagain
approved these changes
May 27, 2021
|
Awesome! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
The core issue is hardware accelarated sse4_crc32 dependency that is suppose to fallback to
javascript implementation but it doesn't since nodejs crashes while loading bindings on M1 chip.
I noticed this issue ashi009/node-fast-crc32c#21 (comment) which actually claims that this lib written in rust even has better performances (library author has no intention on merging this change). I've forked that repo and replaced lib and released under chainsafe org.
I've also updated that dependency in our fork of node-snappy-stream. Hopefully, at some point, somebody (khm google) will force those authors to maintain those "official" libraries.
Tests in all repos are passing and I'm successfully syncing mainnet.
Closes #2475
Steps to test or reproduce