feat: implement produce block v3 and move builder/execution race to beacon #5880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
from
3f85ce9
to
011d1bf
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
philknows
added
the
meta-breaking-change
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
2 times, most recently
from
0481279
to
62d1e97
Compare
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
from
62d1e97
to
62d39f5
Compare
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
from
62d39f5
to
615bd59
Compare
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
2 times, most recently
from
3fc8b40
to
9ae9801
Compare
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
2 times, most recently
from
97aaf8e
to
25c4ab5
Compare
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
2 times, most recently
from
1e88930
to
e9c6aff
Compare
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
3 times, most recently
from
4779c67
to
9ea7037
Compare
dapplion
reviewed
Oct 12, 2023
| @@ -77,45 +82,3 @@ export function processExecutionPayload( | |||
| .getExecutionForkTypes(state.slot) | |||
| .ExecutionPayloadHeader.toViewDU(payloadHeader) as typeof state.latestExecutionPayloadHeader; | |||
| } | |||
|
|
|||
| export function executionPayloadToPayloadHeader( | |||
There was a problem hiding this comment.
Note to self, util moved to packages/state-transition/src/util/execution.ts
|
Mostly cosmetic comments, otherwise looks good |
thank you will address the feedback ❤️ 🙏 |
|
Can you update the description with the lastest? |
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
from
88a2863
to
41abd3e
Compare
|
Is this really a breaking change if the flag is set to false by default? |
it is a lodestar cross version compatibility issue change as the RACE between execution and builder has now moved to beacon (for non produceblockv3 as well), so its both beacon and validator would need to be updated |
updated |
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
from
3daae60
to
e6573f0
Compare
wemeetagain
previously approved these changes
Oct 20, 2023
g11tech
changed the title
g11tech
changed the title
dapplion
reviewed
Oct 21, 2023
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
from
9277614
to
acd897d
Compare
|
@dapplion further resolved the feedback 👍 ❤️ |
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
from
acd897d
to
676e315
Compare
update the impl interfaces Restore the previous versions update test fix oapi spec fix tests fix merge tests fix tests fix the tests implement produce blockv3 refac forktypes plug v3 into vlidator and get it working mock test produceblockv3 and fix issues fix lint fixes update head opts cleanup the validator flags shift fee recipient to extra args as well typo fix tests missed commit deprecate flag instead of removing backward produceblock v2 compatability lint disable produce blockv3 for mixed tests run on only execution sim option fixes improve log pass args fix spell check sort wordlist chore: sort wordlist chore: fix spell check refactor block types and introduce builder/execution race in produceblindedblock api as well fix the publish blinded block to pick locally cached blinded data add flag in get init dev vals fix unit test fixes switch to v2 as default fix issues and run sim tests on mix configurations remove utf8 graffiti from text log apply feedback on api cleanup on the sidecar cache blinded to full utils small produced cache cleanup add metrics cleanup response parsing lint further improv improve interface fix apply feedback
g11tech
force-pushed
the
g11tech/produceblock-v3
branch
from
676e315
to
b643672
Compare
|
🎉 This PR is included in v1.12.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
(for annoucements/release notes)
racehas been moved to beacon (from validator) (via bothproduceBlockV3andproduceBlindedBlock) and hence both validation and beacon will need to be updatedvalidator flag--builderis now deprecated and builder flow activation is solely decided upon--builder.selectionenabledflag underbuildersection. if you do not want to use the builder on a validator that might still be hooked onto a builder enabled beacon, you may provide the builderselectionasexecutiononly(by default its set tomaxprofitbut default still can be overridden with--builder.selectionflag on the validator apart from the proposer config file level overrides)--builder.selection builderonlyflag on the validator to only trigger block production through the builder url configured on the beaconPart of
TODO:
Implements :
- [x] move produceblockv2 and produceblindedblock to the standard beacon apireverted after dicusssion in R&DPS:
this PR doesn't add consensus block value which will be provided in a followup PR