Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always try to fetch optimistic update when starting lc #5977

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

rdvorkin
Copy link
Contributor

Motivation

UX improvement

Description

Currently fetching an optimistic update at client start happens only if a sync is needed. The proposed change tries to fetch an optimistic update even if no sync is needed, e.g. the client was initialized with a recent checkpoint

Currently fetching an optimistic update at client start happens only if a sync is needed. 
The proposed change tries to fetch an optimistic update even if no sync is needed, e.g. the client was initialized with a recent checkpoint
@rdvorkin rdvorkin requested a review from a team as a code owner September 21, 2023 13:38
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech g11tech changed the title feat: Always try to fetch optimistic update when starting lc feat: always try to fetch optimistic update when starting lc Sep 21, 2023
@g11tech g11tech merged commit 9dae25f into ChainSafe:unstable Sep 21, 2023
10 of 13 checks passed
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants