-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use snappy-wasm #6483
Open
wemeetagain
wants to merge
12
commits into
unstable
Choose a base branch
from
cayman/snappy-tweak
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: use snappy-wasm #6483
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0c088c8
feat: use snappy for larger gossip payloads
wemeetagain 68891ee
chore: tweak snappyjs uncompress threshold
wemeetagain 3e24055
Merge branch 'unstable' into cayman/snappy-tweak
wemeetagain 41d4bae
chore: add run factor to snappy benchmark
wemeetagain 864d361
chore: adjust snappyjs thresholds
wemeetagain 53622cd
chore: tweak perf output
wemeetagain b972a2c
Merge branch 'unstable' into cayman/snappy-tweak
wemeetagain 96333a9
feat: use snappy-wasm
wemeetagain a667200
Merge branch 'unstable' into cayman/snappy-tweak
wemeetagain 37d359d
Merge branch 'unstable' into cayman/snappy-tweak
wemeetagain 093a469
feat: use @chainsafe/snappy-wasm with prealloc
wemeetagain 33ca8e7
chore: remove snappy dep
wemeetagain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
packages/beacon-node/test/perf/network/gossip/snappy.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import {randomBytes} from "node:crypto"; | ||
import * as snappyjs from "snappyjs"; | ||
import * as snappy from "snappy"; | ||
import {itBench} from "@dapplion/benchmark"; | ||
|
||
describe("network / gossip / snappy", () => { | ||
const msgLens = [100, 200, 300, 400, 500, 1000, 10000, 100000]; | ||
describe("compress", () => { | ||
for (const msgLen of msgLens) { | ||
const uncompressed = randomBytes(msgLen); | ||
const RUNS_FACTOR = 1000; | ||
|
||
itBench({ | ||
id: `${msgLen} bytes - compress - snappyjs`, | ||
runsFactor: RUNS_FACTOR, | ||
fn: () => { | ||
for (let i = 0; i < RUNS_FACTOR; i++) { | ||
snappyjs.compress(uncompressed); | ||
} | ||
}, | ||
}); | ||
|
||
itBench({ | ||
id: `${msgLen} bytes - compress - snappy`, | ||
runsFactor: RUNS_FACTOR, | ||
fn: () => { | ||
for (let i = 0; i < RUNS_FACTOR; i++) { | ||
snappy.compressSync(uncompressed); | ||
} | ||
}, | ||
}); | ||
} | ||
}); | ||
describe("uncompress", () => { | ||
for (const msgLen of [100, 200, 300, 400, 500, 1000, 10000, 100000]) { | ||
const uncompressed = randomBytes(msgLen); | ||
const compressed = snappyjs.compress(uncompressed); | ||
const RUNS_FACTOR = 1000; | ||
|
||
itBench({ | ||
id: `${msgLen} bytes - uncompress - snappyjs`, | ||
runsFactor: RUNS_FACTOR, | ||
fn: () => { | ||
for (let i = 0; i < RUNS_FACTOR; i++) { | ||
snappyjs.uncompress(compressed); | ||
} | ||
}, | ||
}); | ||
|
||
itBench({ | ||
id: `${msgLen} bytes - uncompress - snappy`, | ||
runsFactor: RUNS_FACTOR, | ||
fn: () => { | ||
for (let i = 0; i < RUNS_FACTOR; i++) { | ||
snappy.uncompressSync(compressed); | ||
} | ||
}, | ||
}); | ||
} | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used to see blocks with 2MB, need to add 2MB, 5MB and 10MB (max size of gossip message) message length