-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use POST variant to get validators from state #6897
Open
nflaig
wants to merge
4
commits into
unstable
Choose a base branch
from
nflaig/use-postStateValidators
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6897 +/- ##
============================================
- Coverage 50.90% 50.89% -0.01%
============================================
Files 594 594
Lines 39611 39613 +2
Branches 2248 2248
============================================
Hits 20163 20163
- Misses 19448 19450 +2 |
Performance Report✔️ no performance regression detected Full benchmark results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
getStateValidators
api has the limitation to only fetch up to 64 pubkeys per request without causing potential issues due URI limits enforced by the server (as pubkeys are sent as part of query).This means the request either fails due to an error by the server if attempting to send too many keys (see #6830) or in case of our indices service, we have to chunk the request in batches with only up 64 keys, this can be really inefficient for nodes running a lot of keys.
Description
Use POST variant to get validators from state, we can send up to ~10k pubkeys per request which for most setups means only a single request. This also reduces the load on the beacon node as it does not have to apply the same filtering logic multiple times.
TODO
Closes #6831