Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor and unit test getDataColumnSidecars #6947

Closed
wants to merge 24 commits into from

Conversation

matthewkeil
Copy link
Member

Motivation

  • Refactor and unit test getDataColumnSidecars
  • Copy fixtures from c-kzg to verify correctness

g11tech and others added 9 commits June 25, 2024 18:57
add types stub and epoch config

fix types
add some presets

add further params and types

add data column to types repo and network

move to max request data columns to preset

add the datacolumns data in blockinput and fix breaking errors in seen gossip blockinput

handle data columns in gossip and the seengossip

further propagate forkaware blockdata and resolve build/type issues

further handle datacolumns sync by range by root and forkaware data handling

fix issues

chore: update c-kzg to peerDas version

feat: add peerDas ckzg functions to interface

fix the lookups

handle the publishing flow

various sync try fixes

fixes

compute blob side car

various misl debuggings and fixes

debug and apply fixes and get range and by root sync to work will full custody

enable syncing with lower custody requirement

use node peerid rather than a dummy string

get and use the nodeid from enr and correctly compute subnets and column indexes

filterout and connect to peers only matching out custody requiremnt

try adding custody requirement

add protection for subnet calc

get the sync working with devnet 0

correctly set the enr with custody subnet info

rebase fixes

small refactor
wip: REPLACE THIS COMMIT

commit yarn lock
@matthewkeil matthewkeil requested a review from a team as a code owner July 12, 2024 20:17
@matthewkeil matthewkeil requested a review from g11tech July 12, 2024 20:17
@matthewkeil matthewkeil requested a review from g11tech July 18, 2024 20:01
packages/beacon-node/src/util/blobs.ts Outdated Show resolved Hide resolved
packages/beacon-node/src/util/blobs.ts Outdated Show resolved Hide resolved
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@matthewkeil
Copy link
Member Author

Replaced by #7072

@matthewkeil matthewkeil closed this Sep 9, 2024
@matthewkeil matthewkeil deleted the mkeil/get-data-column-sidecars branch September 9, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants