Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor KZG API indicating deprecated functions and add recoverCellsAndKzgProofs #7031

Closed
wants to merge 4 commits into from

Conversation

kevaundray
Copy link

Motivation

This adds deprecation notes on the functions that will be deprecated once c-kzg is updated and notes on functions that have been changed slightly.

Description

  • Adds deprecation notes on the functions that will no longer be available
  • Adds recoverCellsAndKzgProofs method which is what the spec now uses
  • Adds a note on verifyCellKzgBatch, sice the API of it changes slightly (rowIndices is no longer available)

Closes #issue_number

Steps to test or reproduce

@kevaundray kevaundray requested a review from a team as a code owner August 16, 2024 18:27
@kevaundray kevaundray changed the title chore: Refactor KZG API indicating deprecated functions chore: Refactor KZG API indicating deprecated functions and add recoverCellsAndKzgProofs Aug 16, 2024
@kevaundray kevaundray changed the title chore: Refactor KZG API indicating deprecated functions and add recoverCellsAndKzgProofs chore: refactor KZG API indicating deprecated functions and add recoverCellsAndKzgProofs Aug 17, 2024
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewkeil
Copy link
Member

Updated to the final DAS c-kzg version to correct method signatures in #7050. We are not currently implementing recoverCellsAndKzgProofs but I did notice that that is exported by c-kzg and am a bit confused by your comment on that one. Why do we need the JS glue code to implement that considering the c-kzg methods called in the JS function were removed?

@kevaundray
Copy link
Author

Updated to the final DAS c-kzg version to correct method signatures in #7050. We are not currently implementing recoverCellsAndKzgProofs but I did notice that that is exported by c-kzg and am a bit confused by your comment on that one. Why do we need the JS glue code to implement that considering the c-kzg methods called in the JS function were removed?

This was only needed if you wanted to make progress without updating c-kzg to the new version -- since you've updated it, you can use this a reference as to what files to remove.

I'll close this as #7050 supercedes it

@kevaundray kevaundray closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants