-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update correlation penalty computation #7071
base: unstable
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7071 +/- ##
============================================
- Coverage 50.89% 50.89% -0.01%
============================================
Files 595 595
Lines 39652 39657 +5
Branches 2258 2060 -198
============================================
Hits 20182 20182
- Misses 19470 19475 +5 |
Performance Report✔️ no performance regression detected Full benchmark results
|
spec tests failing |
New slashing penalty calculation preserves every digit in gwei whereas old calculation is rounded to the nearest 1ETH. So this change doesn't retrofit pre-electra forks and will need to wait for next release of spec test in order to test the correctness of this PR. Will convert to draft for now |
ethereum/consensus-specs#3882 proposes to reformat slashing penalty calculation due to overflow issue.
Lodestar does not have such issue as we've already been tracking everything in increments.
This PR restyle the calculation to be more in line with the spec.
Although spec change supposedly will be live for devnet-4, we can make the code change now for devnet-3 since no functional difference.