Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up from electra review #7102

Merged
merged 1 commit into from
Sep 23, 2024
Merged

chore: clean up from electra review #7102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/beacon-node/src/api/impl/validator/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,7 @@ export function getValidatorApi(

await waitForSlot(slot); // Must never request for a future slot > currentSlot

const dataRootHex = toHex(attestationDataRoot);
const dataRootHex = toRootHex(attestationDataRoot);
const aggregate = chain.attestationPool.getAggregate(slot, null, dataRootHex);
const fork = chain.config.getForkName(slot);

Expand Down
2 changes: 1 addition & 1 deletion packages/beacon-node/src/metrics/metrics/beacon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export function createBeaconMetrics(register: RegistryMetricCreator) {

headState: {
unfinalizedPubkeyCacheSize: register.gauge({
name: "head_state_unfinalized_pubkey_cache_size",
name: "beacon_head_state_unfinalized_pubkey_cache_size",
help: "Current size of the unfinalizedPubkey2Index cache in the head state",
}),
},
Expand Down
4 changes: 2 additions & 2 deletions packages/beacon-node/src/metrics/metrics/lodestar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,11 +381,11 @@ export function createLodestarMetrics(

epochCache: {
finalizedPubkeyDuplicateInsert: register.gauge({
name: "lodestar_epoch_cache_finalized_pubkey_duplicate_insert",
name: "lodestar_epoch_cache_finalized_pubkey_duplicate_insert_total",
help: "Total count of duplicate insert of finalized pubkeys",
}),
newUnFinalizedPubkey: register.gauge({
name: "lodestar_epoch_cache_new_unfinalized_pubkey",
name: "lodestar_epoch_cache_new_unfinalized_pubkey_total",
help: "Total count of unfinalized pubkeys added",
}),
},
Expand Down
2 changes: 1 addition & 1 deletion packages/beacon-node/test/unit/util/sszBytes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {ForkName, MAX_COMMITTEES_PER_SLOT} from "@lodestar/params";
import {
getAttDataFromAttestationSerialized,
getAttDataFromSignedAggregateAndProofPhase0,
getAggregationBitsFromAttestationSerialized as getAggregationBitsFromAttestationSerialized,
getAggregationBitsFromAttestationSerialized,
getBlockRootFromAttestationSerialized,
getBlockRootFromSignedAggregateAndProofSerialized,
getSlotFromAttestationSerialized,
Expand Down
1 change: 0 additions & 1 deletion packages/params/src/presets/mainnet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export const mainnetPreset: BeaconPreset = {
MAX_PENDING_PARTIALS_PER_WITHDRAWALS_SWEEP: 8,
// 2**11 * 10**9 (= 2,048,000,000,000) Gwei
MAX_EFFECTIVE_BALANCE_ELECTRA: 2048000000000,
// 2**16 (= 65536)
MIN_SLASHING_PENALTY_QUOTIENT_ELECTRA: 4096,
MIN_ACTIVATION_BALANCE: 32000000000,
PENDING_BALANCE_DEPOSITS_LIMIT: 134217728,
Expand Down
1 change: 0 additions & 1 deletion packages/params/src/presets/minimal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ export const minimalPreset: BeaconPreset = {
MAX_PENDING_PARTIALS_PER_WITHDRAWALS_SWEEP: 1,
// 2**11 * 10**9 (= 2,048,000,000,000) Gwei
MAX_EFFECTIVE_BALANCE_ELECTRA: 2048000000000,
// 2**16 (= 65536)
MIN_SLASHING_PENALTY_QUOTIENT_ELECTRA: 4096,
MIN_ACTIVATION_BALANCE: 32000000000,
PENDING_BALANCE_DEPOSITS_LIMIT: 134217728,
Expand Down
Loading