feat: switch to compounding from consolidation requests #7122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nc/devnet-4 #7122 +/- ##
==============================================
Coverage ? 48.97%
==============================================
Files ? 596
Lines ? 39825
Branches ? 2059
==============================================
Hits ? 19504
Misses ? 20280
Partials ? 41 |
Performance Report✔️ no performance regression detected Full benchmark results
|
ensi321
force-pushed
the
nc/compounding-switch
branch
from
68aad76
to
37b1b7b
Compare
|
Switching target branch to |
nflaig
reviewed
Oct 10, 2024
packages/state-transition/src/block/processConsolidationRequest.ts
Outdated
Show resolved
Hide resolved
| consolidationRequest: electra.ConsolidationRequest | ||
| ): boolean { | ||
| const {sourcePubkey, targetPubkey, sourceAddress} = consolidationRequest; | ||
| const sourceIndex = state.epochCtx.getValidatorIndex(sourcePubkey); |
There was a problem hiding this comment.
we could save the index lookup if we compare the pubkeys first, not sure if it's worth though but would match more closely to the spec
There was a problem hiding this comment.
we could save the index lookup if we compare the pubkeys first, not sure if it's worth though but would match more closely to the spec
Let's do the optimization later. This part of spec is sub-optimized and will very likely to be cleaned up in alpha 9 or 10. We can optimize when the spec gets refactored.
nflaig
reviewed
Oct 10, 2024
packages/state-transition/src/block/processConsolidationRequest.ts
Outdated
Show resolved
Hide resolved
nflaig
approved these changes
Oct 11, 2024
Merged
|
🎉 This PR is included in v1.23.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec changes
processConsolidationRequestprocessConsolidationRequestwill also switch the request's target validator to compounding instead of waiting untilprocessPendingConsolidationsin epoch processing.applyDeposit.Engineering changes
EpochTransitionCache.newCompoundingValidatorsadded in fix: improve processEffectiveBalanceUpdates #7043 as compound switching now happens in block processing instead of epoch processing. cc @twoeths