Donot show private icon if doi (#425)

* Do not show private icon if any of the versions have DOI

add has_doi field to artifact by looking at versions for doi

* black formatting

* undo new line

sharing_portal/templates/sharing_portal/index.html

@@ -28,7 +28,7 @@ <h3>Featured Artifacts</h3>
           <h5 class="cardItem__title">
             <span class="cardTitleTitle">{{ artifact.title }}</span>
             <span class="cardTitlePrivate">
-          {% if artifact.is_private %}
+          {% if artifact.is_private and not artifact.has_doi %}
             <i class="fa fa-eye-slash" data-toggle="tooltip" data-placement="top"
                title="This artifact is only visible for those chosen by the author"></i>
           {% endif %}
@@ -62,7 +62,7 @@ <h3>All Artifacts</h3>
           <h5 class="cardItem__title">
             <span class="cardTitleTitle">{{ artifact.title }}</span>
             <span class="cardTitlePrivate">
-          {% if artifact.is_private %}
+              {% if artifact.is_private and not artifact.has_doi %}
             <i class="fa fa-eye-slash" data-toggle="tooltip" data-placement="top"
                title="This artifact is only visible for those chosen by the author"></i>
           {% endif %}

sharing_portal/views.py

@@ -266,6 +266,7 @@ def _compute_artifact_fields(artifact):
     terms.extend([f"badge:{badge.badge.name}" for badge in artifact["badges"]])
     artifact["search_terms"] = terms
     artifact["is_private"] = artifact["visibility"] == "private"
+    artifact["has_doi"] = any([_parse_doi(version) for version in artifact["versions"]])
     return artifact