Artifact stats detail page confusion fix #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The artifact details page shows version's stats which is confusing as the list page shows artifac's stats and the details page shows different numbers Also update tool tip for artifact to show 'last updated' and for version stats to show 'created_at'
Mark-Powers
approved these changes
Oct 2, 2023
| @@ -47,7 +47,10 @@ <h2 class="artifactTitle"> | |||
| {{ artifact.long_description|markdown|safe }} | |||
| </section> | |||
|
|
|||
| {% include 'sharing_portal/includes/stats.html' with artifact=artifact version=version %} | |||
| <section class="artifactBody__authors"> | |||
There was a problem hiding this comment.
I think we can leave this without a title, like it was before, as users are expecting these stats are for the whole artifact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact details page shows the version's stats which is confusing as the list page shows the artifact's stats and the details page shows different numbers
Also, update the tooltip for the artifact to show 'last updated at'
Do not show the last update and version count for version stats