Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include publication admin url in the new pub uploaded notification email #429

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Include publication admin url in the new pub uploaded notification email #429

merged 3 commits into from
Nov 3, 2023

Conversation

AnishReddyRavula
Copy link
Contributor

No description provided.

Mark-Powers
Mark-Powers approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Mark-Powers Mark-Powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is just using the __repr__ representation of publication? That seems to include the url, but did you check this isn't using __str__? I'm not certain of the default python behavior for string format.

@AnishReddyRavula
Copy link
Contributor Author

AnishReddyRavula commented Nov 2, 2023 •
edited
Loading

I assume this is just using the __repr__ representation of publication? That seems to include the url, but did you check this isn't using __str__? I'm not certain of the default python behavior for string format.

You are right. I should be using __repr__() explicitly. similar to what I was using for the duplicate notification

@AnishReddyRavula AnishReddyRavula force-pushed the include-url-in-pub-notif branch from c63e8a7 to 87b6aed Compare November 2, 2023 16:13
@AnishReddyRavula AnishReddyRavula merged commit d43f629 into master Nov 3, 2023
12 of 13 checks passed
@AnishReddyRavula AnishReddyRavula deleted the include-url-in-pub-notif branch November 3, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Powers Mark-Powers Mark-Powers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnishReddyRavula @Mark-Powers