Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the badge filter to search the DOM instead of making another request #431

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

AnishReddyRavula
Copy link
Contributor

  • Making another request is very slow as it involves reloading the whole webpage to get the query filter from the URL
  • Using a button tag with a badge image inside it

Not a huge visual change, it is there if you look for it.

Before
image

After
image

Making another request is very slow as it involves reloading the whole webpage to get the query filter from the URL
Copy link
Contributor

@Mark-Powers Mark-Powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple change!

@AnishReddyRavula AnishReddyRavula merged commit 0ead28b into master Nov 13, 2023
13 checks passed
@AnishReddyRavula AnishReddyRavula deleted the trovi-apply-badge-filters-in-js branch November 13, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants