Allocation tests #432
Allocation tests #432
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
flake8
allocations/tests.py|79 col 1| blank line contains whitespace
allocations/tests.py|86 col 1| blank line contains whitespace
allocations/tests.py|88 col 1| blank line contains whitespace
allocations/tests.py|89 col 84| trailing whitespace
allocations/tests.py|90 col 9| continuation line under-indented for visual indent
allocations/tests.py|90 col 33| missing whitespace after ':'
allocations/tests.py|93 col 72| trailing whitespace
allocations/tests.py|97 col 39| trailing whitespace
allocations/tests.py|98 col 31| trailing whitespace
allocations/tests.py|100 col 43| trailing whitespace
allocations/tests.py|103 col 41| trailing whitespace
allocations/tests.py|104 col 42| trailing whitespace
allocations/tests.py|106 col 32| trailing whitespace
allocations/tests.py|108 col 31| trailing whitespace
allocations/tests.py|109 col 26| trailing whitespace
allocations/tests.py|115 col 1| blank line contains whitespace
allocations/tests.py|122 col 1| blank line contains whitespace
allocations/tests.py|126 col 78| trailing whitespace
allocations/tests.py|138 col 1| blank line contains whitespace
allocations/tests.py|140 col 1| blank line contains whitespace
allocations/tests.py|142 col 49| trailing whitespace
allocations/tests.py|143 col 29| trailing whitespace
allocations/tests.py|145 col 43| trailing whitespace
allocations/tests.py|148 col 41| trailing whitespace
allocations/tests.py|149 col 42| trailing whitespace
allocations/tests.py|151 col 32| trailing whitespace
allocations/tests.py|153 col 31| trailing whitespace
allocations/tests.py|154 col 26| trailing whitespace
allocations/tests.py|157 col 1| blank line contains whitespace
allocations/tests.py|159 col 49| trailing whitespace
allocations/tests.py|160 col 29| trailing whitespace
allocations/tests.py|162 col 43| trailing whitespace
allocations/tests.py|165 col 41| trailing whitespace
allocations/tests.py|166 col 42| trailing whitespace
allocations/tests.py|168 col 32| trailing whitespace
allocations/tests.py|170 col 31| trailing whitespace
allocations/tests.py|171 col 26| trailing whitespace
allocations/tests.py|174 col 1| blank line contains whitespace
allocations/tests.py|177 col 1| blank line contains whitespace
allocations/tests.py|179 col 1| blank line contains whitespace
allocations/tests.py|181 col 1| blank line contains whitespace
allocations/tests.py|192 col 1| blank line contains whitespace
allocations/tests.py|194 col 1| blank line contains whitespace
allocations/tests.py|196 col 1| blank line contains whitespace
allocations/tests.py|197 col 84| trailing whitespace
allocations/tests.py|198 col 9| continuation line under-indented for visual indent
allocations/tests.py|198 col 33| missing whitespace after ':'
allocations/tests.py|201 col 74| trailing whitespace
allocations/tests.py|205 col 39| trailing whitespace
allocations/tests.py|206 col 31| trailing whitespace
allocations/tests.py|208 col 43| trailing whitespace
allocations/tests.py|211 col 41| trailing whitespace
allocations/tests.py|212 col 42| trailing whitespace
allocations/tests.py|214 col 32| trailing whitespace
allocations/tests.py|216 col 31| trailing whitespace
allocations/tests.py|217 col 26| trailing whitespace
allocations/tests.py|220 col 1| blank line contains whitespace
allocations/tests.py|223 col 1| blank line contains whitespace
allocations/tests.py|224 col 80| trailing whitespace
allocations/tests.py|226 col 1| blank line contains whitespace
allocations/tests.py|233 col 1| blank line contains whitespace
allocations/tests.py|237 col 1| blank line contains whitespace
allocations/tests.py|239 col 1| blank line contains whitespace
allocations/tests.py|240 col 84| trailing whitespace
allocations/tests.py|241 col 9| continuation line under-indented for visual indent
allocations/tests.py|241 col 33| missing whitespace after ':'
allocations/tests.py|244 col 68| trailing whitespace
allocations/tests.py|248 col 39| trailing whitespace
allocations/tests.py|249 col 30| trailing whitespace
allocations/tests.py|251 col 43| trailing whitespace
allocations/tests.py|254 col 41| trailing whitespace
allocations/tests.py|255 col 42| trailing whitespace
allocations/tests.py|257 col 32| trailing whitespace
allocations/tests.py|259 col 31| trailing whitespace
allocations/tests.py|260 col 26| trailing whitespace
allocations/tests.py|263 col 1| blank line contains whitespace
allocations/tests.py|266 col 1| blank line contains whitespace
allocations/tests.py|267 col 80| trailing whitespace
allocations/tests.py|269 col 1| blank line contains whitespace
allocations/tests.py|273 col 1| blank line contains whitespace
allocations/tests.py|276 col 1| blank line contains whitespace
allocations/tests.py|278 col 1| blank line contains whitespace
allocations/tests.py|279 col 1| blank line contains whitespace
allocations/tests.py|281 col 21| trailing whitespace
allocations/tests.py|283 col 1| blank line contains whitespace
allocations/tests.py|285 col 39| trailing whitespace
allocations/tests.py|286 col 38| trailing whitespace
allocations/tests.py|288 col 1| blank line contains whitespace
allocations/tests.py|293 col 1| blank line contains whitespace
allocations/tests.py|303 col 1| blank line contains whitespace
allocations/tests.py|305 col 1| blank line contains whitespace
allocations/tests.py|310 col 1| blank line contains whitespace
allocations/tests.py|311 col 84| trailing whitespace
allocations/tests.py|312 col 9| continuation line under-indented for visual indent
allocations/tests.py|312 col 33| missing whitespace after ':'
allocations/tests.py|315 col 62| trailing whitespace
allocations/tests.py|319 col 39| trailing whitespace
allocations/tests.py|320 col 29| trailing whitespace
allocations/tests.py|322 col 43| trailing whitespace
allocations/tests.py|325 col 41| trailing whitespace
allocations/tests.py|328 col 32| trailing whitespace
allocations/tests.py|330 col 31| trailing whitespace
allocations/tests.py|331 col 26| trailing whitespace
allocations/tests.py|334 col 1| blank line contains whitespace
allocations/tests.py|336 col 1| blank line contains whitespace
allocations/tests.py|345 col 1| blank line contains whitespace
allocations/tests.py|347 col 39| trailing whitespace
allocations/tests.py|348 col 48| trailing whitespace
allocations/tests.py|351 col 1| blank line contains whitespace
allocations/tests.py|355 col 1| blank line contains whitespace
allocations/tests.py|356 col 84| trailing whitespace
allocations/tests.py|357 col 9| continuation line under-indented for visual indent
allocations/tests.py|357 col 33| missing whitespace after ':'
allocations/tests.py|360 col 70| trailing whitespace
allocations/tests.py|364 col 39| trailing whitespace
allocations/tests.py|365 col 29| trailing whitespace
allocations/tests.py|367 col 43| trailing whitespace
allocations/tests.py|370 col 41| trailing whitespace
allocations/tests.py|373 col 32| trailing whitespace
allocations/tests.py|375 col 31| trailing whitespace
allocations/tests.py|376 col 26| trailing whitespace
allocations/tests.py|379 col 1| blank line contains whitespace
allocations/tests.py|381 col 1| blank line contains whitespace
allocations/tests.py|386 col 1| blank line contains whitespace
allocations/tests.py|388 col 39| trailing whitespace
allocations/tests.py|389 col 52| trailing whitespace
allocations/tests.py|391 col 1| blank line contains whitespace
allocations/tests.py|395 col 1| blank line contains whitespace
allocations/tests.py|396 col 1| blank line contains whitespace
allocations/tests.py|397 col 1| blank line contains whitespace
allocations/tests.py|398 col 1| blank line contains whitespace
allocations/tests.py|399 col 1| blank line contains whitespace
allocations/tests.py|400 col 1| blank line contains whitespace
chameleon/settings.py|924 col 1| blank line at end of file
There was a problem hiding this comment.
This looks good! Just a few minor comments + can you fix the formatting issues the bot commented?
Regarding deploying, since this doesn't actually change the running code, it should be fine to deploy (or just wait until we deploy something else). We should set up this as a github action eventually, but for now we can at least test it while developing locally.
chameleon/settings.py
Outdated
| @@ -145,7 +145,7 @@ | |||
| "djangocms_picture", | |||
| "djangocms_snippet", | |||
| "djangocms_video", | |||
| "reversion", | |||
| # "reversion", | |||
There was a problem hiding this comment.
Can you un-commit this change? I think it's just a local-dev quirk we need to figure out with a proper test DB fix in the future.
| @@ -257,6 +257,9 @@ | |||
| "PORT": os.environ.get("DB_PORT"), | |||
| "USER": os.environ.get("DB_USER"), | |||
| "PASSWORD": os.environ.get("DB_PASSWORD"), | |||
| "TEST": { | |||
There was a problem hiding this comment.
Is this built into the django database connection spec or something? I can't find reference to it.
There was a problem hiding this comment.
Yes, this is mentioned in django docs
The default test database names are created by prepending test_ to the value of each NAME in DATABASES. When using SQLite, the tests will use an in-memory database by default (i.e., the database will be created in memory, bypassing the filesystem entirely!). The TEST dictionary in DATABASES offers a number of settings to configure your test database. For example, if you want to use a different database name, specify NAME in the TEST dictionary for any given database in DATABASES.
…y of test runs including error logs for the 15 tests that do not run. uncommiting the reversion change from settings
|
@AnishReddyRavula @Mark-Powers Added a Test summary report detailing which of our 37 tests fail and a summarized error report in TestSummary.md |
Added testing for allocations tasks and added instructions on how to run tests that require a DB connection