Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocations admin view (read only) #433

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Conversation

AnishReddyRavula
Copy link
Contributor

@AnishReddyRavula AnishReddyRavula commented Jan 24, 2024

This does not replace the existing allocatins approval page

Read only and cannot be used to change details

This is done so project manager can look at allocations and use that data to get insights into them

This does not replace the existing allocatins approval page

Read only and cannot be used to change details

This is done so project manager can look at allocations and use that data to get insights into them
def has_change_permission(self, request, obj=None):
return False

list_display= (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <225> reported by reviewdog 🐶
missing whitespace around operator

Copy link
Contributor

@Mark-Powers Mark-Powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@marcwitasee
Copy link

@AnishReddyRavula I need information about the project content as well. For example, the description and the title of the project. I also would need to see the allocation justification and whether the allocation was approved as a renewal, new allocation, or a recharge. Is it possible to include that information in this view as well? Oh and also some information about the requester, name, email, affiliation.

@AnishReddyRavula
Copy link
Contributor Author

@AnishReddyRavula I need information about the project content as well. For example, the description and the title of the project. I also would need to see the allocation justification and whether the allocation was approved as a renewal, new allocation, or a recharge. Is it possible to include that information in this view as well? Oh and also some information about the requester, name, email, affiliation.

  • Renewal or new or recharge information cannot be shown as they are just placeholders on the other page to show the appropriate text, may be you can understand if that is new/renewal/recharge by looking at the Decision summary.
  • I can do the description and title of the project.
  • I added the PI's name email and institution. But let me know if you also need requesters' to be seen on the same page. Requester will be mostly PI but can also be PI delegate. requesters name, username will be shown though

@@ -1,4 +1,60 @@
from django.conf import settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8] <401> reported by reviewdog 🐶
'django.conf.settings' imported but unused

@AnishReddyRavula AnishReddyRavula merged commit 771099d into master Feb 12, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants