Soufianej edge hw discovery page v1.0 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JOUNAIDSoufiane
requested review from
Mark-Powers and
AnishReddyRavula
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Mark-Powers
approved these changes
Mar 27, 2024
chameleon/settings.py
Outdated
| # Edge HW Discovery API | ||
| # | ||
| ##### | ||
| EDGE_HW_ROOT = "http://host.docker.internal:5000" |
There was a problem hiding this comment.
Is this being deployed with the same docker compose file as portal? This should then be the docker service name, like for the g5k api above.
If it'll be deployed elsewhere, this should read from an env variable.
There was a problem hiding this comment.
yup I was just going to ask about this. This is temporary
Mark-Powers
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChameleonCloud/edge-hw-discovery@c2794dc commit description contains an overview of what is done and what can be added