Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help desk button for logged out users. #476

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

Mark-Powers
Copy link
Contributor

If a user is authenticated, they are correctly redirected to the "logged in" form, so it's safe to always link to guest form. I

In case users were using this button to go to "My tickets" instead of submitting a new one, it now conditionally updates the menu bar link to handle this.

Copy link
Contributor

@msherman64 msherman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice!

@Mark-Powers Mark-Powers merged commit 17330bf into master Oct 14, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants