Add details to pub list, and fix perms #512
Open
+160
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Powers
commented
Dec 20, 2024
| @@ -69,16 +68,25 @@ def user_publications(request): | |||
| try: | |||
| del_pub_id = request.POST["pub_ref"] | |||
| logger.debug("deleting publication with id {}".format(del_pub_id)) | |||
| Publication.objects.get(pk=del_pub_id).delete_pub() | |||
| pub = Publication.objects.get(pk=del_pub_id) | |||
| if pub.added_by_username != request.user.username: | |||
There was a problem hiding this comment.
This is the permissions fix change
Mark-Powers
commented
Dec 20, 2024
| except Exception: | ||
| logger.exception("Failed removing publication") | ||
| messages.error( | ||
| request, | ||
| "An unexpected error occurred while attempting " | ||
| "to remove this publication. Please try again", | ||
| ) | ||
| mapper = ProjectAllocationMapper(request) |
There was a problem hiding this comment.
This section now queries for publications for all of the user projects, not just publications the user has submitted.
msherman64
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds review information to publications in the list view. Also now shows publications from all of a user's projects, not just those they have submitted (which was confusing with managers). Also fixes a delete permission issue: we were not checking ownership at all, and this ensures only the owner can delete what they have submitted.