Add third party plugins #26
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| # Copyright (c) 2019 StackHPC Ltd. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| # implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from blazarclient import base | ||
| from blazarclient.i18n import _ | ||
|
|
||
| import logging | ||
| LOG = logging.getLogger(__name__) | ||
|
|
||
| class ResourceClientManager(base.BaseClientManager): | ||
|
There was a problem hiding this comment. Most of the dict lookups in this class assume that the server will also have plugins installed. Is this assumption safe to make? There was a problem hiding this comment. I think this is fine, as blazar already assumes you have oshosts/network/fip running. There is a |
||
| def list_resources(self, sort_by=None): | ||
| resp, body = self.request_manager.get('/resources') | ||
| if sort_by: | ||
| resources = sorted(body, key=lambda l: l[sort_by]) | ||
|
There was a problem hiding this comment. This variable is unused, and |
||
| return body | ||
|
|
||
| def create(self, resource_type, data, **kwargs): | ||
| values = {'data': data} | ||
| values.update(**kwargs) | ||
| resp, body = self.request_manager.post(f'/{resource_type}', body=values) | ||
| return body['resource'] | ||
|
|
||
| def get(self, resource_type, resource_id): | ||
| resp, body = self.request_manager.get( | ||
| f'/{resource_type}/{resource_id}') | ||
| return body['resource'] | ||
|
|
||
| def update(self, resource_type, res_id, data, extras): | ||
| LOG.info("RESOURCE CLIENT UPDATE") | ||
|
|
||
| if not data and not extras: | ||
| return _('No information to update passed.') | ||
| LOG.info(data) | ||
| LOG.info(extras) | ||
| body = {"data": data, "extras": extras} | ||
| resp, body = self.request_manager.put( | ||
| f'/{resource_type}/{res_id}', body=body | ||
| ) | ||
| return body['resource'] | ||
|
|
||
| def delete(self, resource_type, resource_id): | ||
| resp, body = self.request_manager.delete( | ||
|
|
||
| f'/{resource_type}/{resource_id}') | ||
|
|
||
| def list(self, resource_type, sort_by=None): | ||
| resp, body = self.request_manager.get(f'/{resource_type}') | ||
| resources = body['resources'] | ||
| if sort_by: | ||
| resources = sorted(resources, key=lambda l: l[sort_by]) | ||
| return resources | ||
|
|
||
| def get_allocation(self, resource_type, resource_id): | ||
| resp, body = self.request_manager.get( | ||
| f'/{resource_type}/{resource_id}/allocation') | ||
| return body['allocation'] | ||
|
|
||
| def list_allocations(self, resource_type, sort_by=None): | ||
| resp, body = self.request_manager.get(f'/{resource_type}/allocations') | ||
| allocations = body['allocations'] | ||
| if sort_by: | ||
| allocations = sorted(allocations, key=lambda l: l[sort_by]) | ||
| return allocations | ||
|
|
||
| def reallocate(self, resource_type, resource_id, values): | ||
| resp, body = self.request_manager.put( | ||
| f'/{resource_type}/{resource_id}/allocation', body=values) | ||
| return body['allocation'] | ||
|
|
||
| def list_capabilities(self, resource_type, detail=False, sort_by=None): | ||
| url = f'/{resource_type}/properties' | ||
|
|
||
| if detail: | ||
| url += '?detail=True' | ||
|
|
||
| resp, body = self.request_manager.get(url) | ||
| resource_properties = body['resource_properties'] | ||
|
|
||
| # Values is a reserved word in cliff so need to rename values column. | ||
| if detail: | ||
| for p in resource_properties: | ||
| p['capability_values'] = p['values'] | ||
| del p['values'] | ||
|
|
||
| if sort_by: | ||
| resource_properties = sorted(resource_properties, | ||
| key=lambda l: l[sort_by]) | ||
| return resource_properties | ||
|
|
||
| def get_capability(self, resource_type, capability_name): | ||
| resource_property = [ | ||
| x for x in self.list_capabilities(resource_type, detail=True) | ||
| if x['property'] == capability_name] | ||
|
|
||
| return {} if not resource_property else resource_property[0] | ||
|
|
||
| def set_capability(self, resource_type, capability_name, private): | ||
| data = {'private': private} | ||
| resp, body = self.request_manager.patch( | ||
| f'/{resource_type}/properties/{capability_name}', body=data) | ||
|
|
||
| return body['resource_property'] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branching is a little difficult to parse at first glance. I prefer consolidating a little bit