added filter argument to tar.extactall when extracting downloaded file in container.download() #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e incontainer.download()
JOUNAIDSoufiane
requested review from
Mark-Powers and
msherman64
as code owners
msherman64
reviewed
Mar 20, 2024
| @@ -98,7 +98,7 @@ def create_container( | |||
| kwargs["exposed_ports"] = exposed_ports | |||
|
|
|||
| # Note: most documented args are not on the function signature because there is some special | |||
| # handling of it in the Zun client; it is not sent if it is not on kwargs. | |||
| # handling of it in the Zu n client; it is not sent if it is not on kwargs. | |||
| @@ -236,7 +236,7 @@ def download(container_ref: "str", source: "str", dest: "str"): | |||
| res = zun().containers.get_archive(container_ref, source) | |||
| fd = io.BytesIO(res["data"]) | |||
| with tarfile.open(fileobj=fd, mode="r") as tar: | |||
| tar.extractall(dest) | |||
| tar.extractall(dest, filter="fully_trusted") | |||
There was a problem hiding this comment.
does this cause any issues if you run an older version of the library?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tar.extractall() or tar.extract() are now both deprecated if a filter argument is not specified.
see https://docs.python.org/3/library/tarfile.html#extraction-filters and mindsdb/mindsdb#8927