-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change MARX to automake #16
Open
hamogu
wants to merge
111
commits into
Chandra-MARX:alan
Choose a base branch
from
hamogu:am2
base: alan
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .gitignores contain the autotools files at the location wehre I finally want them when I'm doen with the autmomake conversion.
Move test for enidanness into autoconf. Previously, a Makefile would compile and run a special program that tested system characteristics nad wrote an output file, which in turn would be inlcuded as a header file. This task is better left to autoconf.
This proved more difficult than expected; in particular to pick the right inputs for libmarx.a (which is far more than the *lis file states). Because everything depends on everything (the directory structure on configure.ac, the configure.ac on automake, automake on my ability ot formulate the right rules, ...) this is not a small atomic commit but rather a "dumb everything in one buckt". At this point automake + autoconf + autoheader work and compile (I did not test if marx runs, yet!). There is no use of libtool yet.
Also, change their installation location from /lib/marx to /bin. This puts all binary executables in one place.
This file has not changed for 10 years and it's not big. It is much simpler to include the binary in the distribution tarball. (It's been in the repro for a long time anyway).
This proved more difficult than expected; in particular to pick the right inputs for libmarx.a (which is far more than the *lis file states). Because everything depends on everything (the directory structure on configure.ac, the configure.ac on automake, automake on my ability ot formulate the right rules, ...) this is not a small atomic commit but rather a "dumb everything in one buckt". At this point automake + autoconf + autoheader work and compile (I did not test if marx runs, yet!). There is no use of libtool yet.
Also, change their installation location from /lib/marx to /bin. This puts all binary executables in one place.
This file has not changed for 10 years and it's not big. It is much simpler to include the binary in the distribution tarball. (It's been in the repro for a long time anyway).
pfiles, jdfits, and jdmath all have their own configure and makefiles. This commit introduces the same for rsp. In particular since rsp needs cfitsio, while the main program does not, it seems reasonble to build it separately.
At this stage, all automake and autoconf files do work and compile all tools sucessfully. The conversion to automake is not complete (e.g. rsp should only be compiled if cfitsio is available and the autput of running marx should print useful messages where data and par files can be found).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MARX has used autoconf for a long time. This PR changes the system from partially hand-written makefiles and custom m4 macros to automake and standard m4 macros.