bitbang: Fix FTBFS with GCC 10 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 10 defaults to -fno-common which breaks the sharing of bitbang_swd struct between bitbang drivers due to a missing extern. Change-Id: I2b4122f7939cec91a72284006748f99a23548324 Signed-off-by: Andreas Fritiofson <[email protected]> Reviewed-on: http://openocd.zylin.com/5592 Tested-by: jenkins Reviewed-by: Antonio Borneo <[email protected]> Reviewed-by: Jonathan McDowell <[email protected]>
matthewtraughber
force-pushed
the
master
branch
from
2cb4a4e
to
af4a8ec
Compare
|
af4a8ec can be removed from this PR, but it was required in order to get the RPi4B working as a debugger. |
|
Might be better to rebase with latest changes (like done here: mateuszradomski/re-masterkeys#1 (comment)). Had a better experience building on my RPi4B this way. |
Thanks for the link. I initially attempted a rebase, but ran into other issues. This patch was the minimum changes needed to get things working on my end. If you were able to successfully rebase, then perhaps throw your changes up as a PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to build
openocd-ht32with a recent version of GCC.GCC 10 defaults to -fno-common which breaks the sharing of bitbang_swd struct between bitbang drivers due to a missing extern.
Change-Id: I2b4122f7939cec91a72284006748f99a23548324
Signed-off-by: Andreas Fritiofson [email protected]
Reviewed-on: http://openocd.zylin.com/5592
Tested-by: jenkins
Reviewed-by: Antonio Borneo [email protected]
Reviewed-by: Jonathan McDowell [email protected]