Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deepseek): deepseek should not check Moonshot ServiceProvider #6008

Closed
wants to merge 1 commit into from

Conversation

CharlinChen
Copy link

@CharlinChen CharlinChen commented Dec 30, 2024

fix you are not allowed to use DeepSeek model error without Moonshot settings

💻 变更类型 | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 变更说明 | Description of Change

使用deepseek时提示you are not allowed to use DeepSeek model,经查阅,字符串未替换完全,导致检查的是月之暗面的ServiceProvider。

📝 补充信息 | Additional Information

Summary by CodeRabbit

  • Bug Fixes
    • Updated service provider configuration for model availability checks
    • Improved model validation logic to support DeepSeek service provider

fix `you are not allowed to use DeepSeek model` error without Moonshot settings
Copy link

vercel bot commented Dec 30, 2024

@CharlinChen is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Dec 30, 2024

Walkthrough

The pull request modifies the app/api/deepseek.ts file, specifically updating the service provider reference from ServiceProvider.Moonshot to ServiceProvider.DeepSeek within the request function. This change impacts the model availability check logic, ensuring that the correct service provider is used when determining whether a model can be utilized based on the server's configuration.

Changes

File Change Summary
app/api/deepseek.ts Updated service provider from Moonshot to DeepSeek in model availability check

Possibly related PRs

Suggested reviewers

  • Dogtiti

Poem

🐰 A DeepSeek hop, a provider's dance,
Code shifts with a rabbit's glance,
From Moonshot to new frontier's light,
Service provider takes its flight!
Configurations bloom anew 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
app/api/deepseek.ts (1)

94-94: Good fix for the bug.

Switching the service provider from Moonshot to DeepSeek aligns with the PR objective and fixes the unintended provider check. As a small note, casting ServiceProvider.DeepSeek to string may be redundant if ServiceProvider.DeepSeek is already a string. If so, consider removing the cast to simplify the code.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d56566c and d0aac59.

📒 Files selected for processing (1)
  • app/api/deepseek.ts (1 hunks)

@Dogtiti
Copy link
Member

Dogtiti commented Dec 31, 2024

#6016

@Dogtiti Dogtiti closed this Dec 31, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


#6016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants