feat(notifications): show user avatar when sending live notification on Linux #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
reviewed
Feb 22, 2025
There was a problem hiding this comment.
- do I need to check for
hasAvatarForChannel(channelName)or can I assume this will be true oncesendLibnotifyis called?
You shouldn't need it. gdk_pixbuf_new_from_file should error if the file doesn't exist when it tries to open it.
- Is
g_object_unref(img)the correct way of 'freeing' the buffer? I copied it from here.
That should be correct. notify_notification_set_image_from_pixbuf stores a reference and increments the refcount, so one unref on our side is needed.
pajlada
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add avatar images to live notifications in the libnotify implementation.
Fixes #5938
There are two things I am unsure about:
hasAvatarForChannel(channelName)or can I assume this will be true oncesendLibnotifyis called?g_object_unref(img)the correct way of 'freeing' the buffer? I copied it from here.