Allow using Environment creds on AWS #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have added/changed is:
I added the ability for the agent to pick up cred from the env. Rather than forcing users to use IAM user (by asking for access key and secret key), this allows users to user to use IAM roles. When running the agent on AWS, ideally you won't use IAM user because within AWS you have access to IAM roles. IAM roles have session timeout where IAM users do not which would prevent abuse of access if someone gain access to your creds.
The goal of my change is:
Allow a safer way to run the agent on AWS by allowing user to use IAM role rather than IAM user.
What I have tested about my change is:
Tested, working on EC2.