add: Round service

[pyropy]

This pull request introduces the new round service and the the new checker_rounds database table. The changes include configuration updates, the implementation of the round, database schema modifications, and new tests to ensure the functionality of the round service.

Round service will create a new round in the given interval. Upon creation of the new round task sampling is triggered and old rounds (if there are any) are set to inactive whilst the new round is set to active.

Round service should run in the background and generate the new rounds until the process is stopped.

Change log:

• Implemented the RoundService class in lib/round-service.js to manage the lifecycle of rounds, including starting, stopping, and transitioning between rounds.
• Added the TaskingService class in lib/tasking-service.js to handle task generation for each round, although the task generation logic is not yet implemented.
• Added roundServiceConfig and taskingServiceConfig to poolConfig in lib/config.js to configure round duration, maximum tasks per node, and interval for checking round status.
• Created a new table checker_rounds in migrations/003.do.checker-rounds.sql to store round information, including start and end times, active status, and maximum tasks per node.
• Added tests for the RoundService in test/round-service.test.js to verify the creation and resumption of rounds, stopping the service, and transitioning between rounds.

Closes #35
Related to:

• Build Centralized Tasking System #32
• add: Tasking service #47

[Copilot]

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

• migrations/003.do.checker-rounds.sql: Language not supported

[Copilot]

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)

• migrations/003.do.checker-rounds.sql: Language not supported

[juliangruber]

What is the purpose of the active field? Can we simplify this to querying what is the last round where end_time > NOW()?

[pyropy]

Motivation behind the active field was to switch on round to active after the task creation. Unlike the implementation in the spark-api where tasks are created during the round creation on the database level, here we call TaskingService to create tasks for the round.

Thing that I'm questioning is should we or should we not leave the last round as active in case the TaskingService fails to sample / insert tasks for the new round?

[juliangruber]

Got it, you can only consider the round active once tasks have been sampled, but you can also only sample tasks once the round exists, right?

Can we then rename active to has_had_tasks_defined? This way the purpose to me is more clear. Another way is to JOIN on the tasks for that round, and simply consider any round as inactive if it has no matching tasks. This assumes we don't want to have empty rounds.

[Copilot]

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (1)

• migrations/003.do.checker-rounds.sql: Language not supported

Comments suppressed due to low confidence (1)

lib/round-service.js:144

• The log statement references 'round.startTime', but the returned property from the SQL query is 'start_time'. Update the log to use 'round.start_time' for consistency.

console.log(`Created new round #${round.id} starting at ${round.startTime}`)

[juliangruber]

Can this be inferred from lib/config.js? Something like type RoundConfig = typeof config.roundServiceConfig

[juliangruber]

why is this key not private as well?

[juliangruber]

This code is repeated in #initializeRound() can we refactor into a function #maybeStartNewRound()?

[juliangruber]

Got it, you can only consider the round active once tasks have been sampled, but you can also only sample tasks once the round exists, right?

Can we then rename active to has_had_tasks_defined? This way the purpose to me is more clear. Another way is to JOIN on the tasks for that round, and simply consider any round as inactive if it has no matching tasks. This assumes we don't want to have empty rounds.