Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spark TTFB poc #434

Merged
merged 26 commits into from
Jan 14, 2025
Merged

Spark TTFB poc #434

merged 26 commits into from
Jan 14, 2025

Conversation

pyropy
Copy link
Contributor

@pyropy pyropy commented Dec 23, 2024 •
edited
Loading

  • Adds retrieval time stats to public stats

Relates to CheckerNetwork/roadmap#208

@pyropy pyropy changed the title Spark ttfb poc Spark TTFB poc Dec 27, 2024
@pyropy pyropy self-assigned this Dec 27, 2024
@juliangruber
Copy link
Member

Quoting @pyropy:

I left them (the PRs) as draft as I am unsure if there is a way to reference spark-evaluate commit from spark-stats and I am not sure if we should have another section for ttfb on dashboard

juliangruber
juliangruber requested changes Jan 5, 2025
View reviewed changes
lib/committee.js Outdated Show resolved Hide resolved
lib/preprocess.js Outdated Show resolved Hide resolved
lib/public-stats.js Outdated Show resolved Hide resolved
lib/public-stats.js Outdated Show resolved Hide resolved
lib/public-stats.js Outdated Show resolved Hide resolved
@juliangruber
Copy link
Member

Quoting @pyropy:

I left them (the PRs) as draft as I am unsure if there is a way to reference spark-evaluate commit from spark-stats and I am not sure if we should have another section for ttfb on dashboard

I'm marking this as ready for review as the open questions don't affect this PR and I think it can be merged as soon as reviews pass

@juliangruber juliangruber marked this pull request as ready for review January 5, 2025 21:50
bajtos
bajtos requested changes Jan 9, 2025
View reviewed changes
lib/public-stats.js Outdated Show resolved Hide resolved
lib/public-stats.js Outdated Show resolved Hide resolved
migrations/021.do.add-retrieval-times.sql Outdated Show resolved Hide resolved
test/public-stats.test.js Outdated Show resolved Hide resolved
pyropy
pyropy commented Jan 13, 2025
View reviewed changes
lib/public-stats.js Outdated Show resolved Hide resolved
@pyropy pyropy mentioned this pull request Jan 13, 2025
Merged
bajtos
bajtos approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 💪🏻

lib/public-stats.js Outdated Show resolved Hide resolved
lib/public-stats.js Outdated Show resolved Hide resolved
lib/public-stats.js Show resolved Hide resolved
test/public-stats.test.js Outdated Show resolved Hide resolved
test/public-stats.test.js Outdated Show resolved Hide resolved
test/public-stats.test.js Outdated Show resolved Hide resolved
@bajtos bajtos requested a review from juliangruber January 13, 2025 14:57
bajtos
bajtos requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, I meant to request changes.

@pyropy pyropy mentioned this pull request Jan 13, 2025
Open
2 tasks
@pyropy pyropy requested a review from bajtos January 14, 2025 09:13
bajtos
bajtos approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏻

test/public-stats.test.js Outdated Show resolved Hide resolved
@pyropy pyropy merged commit d236813 into main Jan 14, 2025
6 checks passed
@pyropy pyropy deleted the spark-ttfb-poc branch January 14, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@NikolasHaimerl NikolasHaimerl Awaiting requested review from NikolasHaimerl NikolasHaimerl is a code owner

@juliangruber juliangruber Awaiting requested review from juliangruber juliangruber is a code owner

Assignees

@pyropy pyropy

Labels
None yet
Projects
Space Meridian
Status: ✅ done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyropy @juliangruber @bajtos