Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retrieval activity logs #41

Closed
wants to merge 5 commits into from
Closed

Add retrieval activity logs #41

wants to merge 5 commits into from

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Nov 17, 2023 •
edited
Loading

To help Station operators understand what's going on

@juliangruber juliangruber requested a review from bajtos November 17, 2023 14:53
@juliangruber
Copy link
Member Author

https://github.com/filecoin-station/spark/releases/tag/v1.6.0-rc.1

@juliangruber
Copy link
Member Author

CheckerNetwork/core#266

This was referenced Nov 17, 2023
Closed
Closed
bajtos
bajtos approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; with a few suggestions that can be applied in a follow-up PR if you like.

lib/spark.js Outdated Show resolved Hide resolved
lib/spark.js Show resolved Hide resolved
@juliangruber juliangruber requested a review from bajtos November 20, 2023 11:19
bajtos
bajtos reviewed Nov 20, 2023
View reviewed changes
lib/spark.js Outdated Show resolved Hide resolved
@bajtos
Copy link
Member

bajtos commented Nov 20, 2023

On the second though, I am not sure if this PR is a good idea. I think we will overload the user with too many detailed messages that will make it difficult to notice the important ones.

If we want to show progress, then aggregated information printed once every X seconds is a better approach, IMO. We are already discussing new activity logs here: CheckerNetwork/desktop#1123

To allow our users to troubleshoot Station behaviour in details, the current "Save Module Logs as" approach is IMO better. We can review what messages is SPARK printing to this log file via console.log and console.error APIs and add more logging where needed.

Thoughts?

/cc @patrickwoodhead

@juliangruber
Copy link
Member Author

I agree that showing summaries is more effective from a data perspective than reporting any individual retrieval. Let's revisit in our call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Space Meridian
Status: ✅ done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangruber @bajtos