Skip to content

Conversation

cx-andre-pereira
Copy link
Contributor

@cx-andre-pereira cx-andre-pereira commented Sep 29, 2025

Reason for Proposed Changes

Proposed Changes

  • The types array was expanded on both queries to include all relevant resources; moreover tests analog to the existing ones were added for each one of them.
  • Additionally some of the "SQLServer Ingress From Any IP" query's negative tests were expanded.

I submit this contribution under the Apache-2.0 license.

Copy link

gitguardian bot commented Sep 29, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
21271469 Triggered Generic Password 749c70e assets/queries/terraform/azure/unrestricted_sql_server_access/test/positive3.tf View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions github-actions bot added query New query feature terraform Terraform query azure PR related with Azure Cloud labels Sep 29, 2025
Copy link
Contributor

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-andre-pereira cx-andre-pereira marked this pull request as ready for review September 29, 2025 14:31
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner September 29, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure PR related with Azure Cloud query New query feature terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant