Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.0 #385

Merged
merged 84 commits into from
Jul 31, 2023
Merged

Release 2.4.0 #385

merged 84 commits into from
Jul 31, 2023

Conversation

robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented Jul 17, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: e.g. #1

What is the new behavior?

Other information

robin-checkmk and others added 30 commits April 19, 2023 13:53
Before this change, it could occur, that no services were added during discovery, because no information was yet available. With the updated task, we ensure, that current data is there. Also we only add new services, as a removal of services would indicate a subsequent run of the role and the removal would be undesired there.
…shed, retry fetch_url if time out 3 times each time doubling the time out time
@robin-checkmk robin-checkmk marked this pull request as ready for review July 28, 2023 15:43
@robin-checkmk
Copy link
Member Author

We will ignore the Molecule failures for the agent role at this point, as they do not indicate an actual problem with the current code. We will address that issue at a later time.

@robin-checkmk robin-checkmk merged commit 2f1e775 into main Jul 31, 2023
17 of 23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
@robin-checkmk robin-checkmk added release:2.4.0 Affects the mentioned release. and removed release:4.2.0 Affects the mentioned release. labels Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module:discovery This affects the discovery module release:2.4.0 Affects the mentioned release. role:agent This affects the agent role role:server This affects the server role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants