Fix module folder for future checkmk releases

[msekania]

Fixes issue #389

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Currently all three options attributes, remove_attributes, and update_attributes can be used simultaneously, which is no longer supported by API for Check MK >= v2.2.0p7

Issue Number: #389

What is the new behavior?

• issue a warning message if more then one option from attributes, remove_attributes, and update_attributes is used simultaneously for Check MK < v2.2.0p7
• fail with error message if more then one option from attributes, remove_attributes, and update_attributes is used simultaneously for Check MK >= v2.2.0p7

Other information

[robin-checkmk]

@msekania thanks for tackling this!
Is your branch up-to-date with our devel? Looks like there are some unrelated changes in here.

[msekania]

Is your branch up-to-date with our devel? Looks like there are some unrelated changes in here.

apparently not, changes should be only in folder.py

[robin-checkmk]

I'll take a look at the failing tests and the weirdness with the additional changes.

[msekania]

@robin-checkmk

thanks!

[robin-checkmk]

I understand the issue with the integration tests now but the solution is not trivial.
I pushed a hotfix, but that is not final yet.
@msekania the current results indicate, that there is an actual issue with the module. Can you take a look?

[msekania]

So the current test findings should be valid, and if you pull the devel branch into yours, the integration tests should be fixed properly.

@robin-checkmk, not sure whether it got better, even more files are now altered

[robin-checkmk]

@msekania did you pull the devel branch, or did you rebase or something different? It looks indeed weird, but we can figure this out for sure. If you can check the integration test findings, we should get through this.

[msekania]

@robin-checkmk,

I pulled devel branch, and merged it in the current, which required rebase.

[msekania]

@robin-checkmk,

alternative solution, when tests go through successfully, I can create a new pull request branching out from the actual devel branch and moving only folder.py and close this PR.

just let me know what do you think.

[robin-checkmk]

@msekania I am uncertain what exactly happened, but I think your idea of creating a new and clean PR is the best approach. Go ahead and create it, I will merge tomorrow then and release.
Thanks!

P.S.: The failing molecule test is irrelevant.