Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for lookup plugin 'version' #421

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Add integration tests for lookup plugin 'version' #421

merged 2 commits into from
Aug 24, 2023

Conversation

robin-checkmk
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There are no integration tests for the lookup plugin version.

What is the new behavior?

Integration tests are implemented.

Other information

@robin-checkmk robin-checkmk self-assigned this Aug 22, 2023
@robin-checkmk robin-checkmk added release:3.2.0 Affects the mentioned release. lookup:version This affects the lookup module 'version'. labels Aug 22, 2023
lgetwan
lgetwan approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@lgetwan lgetwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to test this in my local repo, but the tests here in github look fine, and their logic makes sense.

@lgetwan
Copy link
Contributor

lgetwan commented Aug 24, 2023

Thanks for creating that integration test...

@robin-checkmk robin-checkmk merged commit 308368e into devel Aug 24, 2023
27 checks passed
@robin-checkmk robin-checkmk deleted the feature/add-int-tests-lookup-version branch August 24, 2023 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgetwan lgetwan lgetwan approved these changes

Assignees

@robin-checkmk robin-checkmk

Labels
lookup:version This affects the lookup module 'version'. release:3.2.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robin-checkmk @lgetwan