Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature cme support #424

Closed
wants to merge 17 commits into from
Closed

Conversation

muehlings
Copy link
Contributor

@muehlings muehlings commented Aug 23, 2023

Adds the neccessary parameter "customer" to the corresponding CME API endpoints in the ansible modules.

  • user.py
  • host_group.py

Pull request type

Please check the type of change your PR introduces:

  • Feature

What is the current behavior?

Issue Number: #65

What is the new behavior?

  • Make ansible modules ready for Checkmk CME API endpoints.

TODO:

  • Identify all modules who need the "customer" parameter.
  • Modify the POST/PUT logic? I think the other Checkmk versions will fail at requests with additional parameters.

Other information

@github-actions github-actions bot added role:server This affects the server role module:host_group This affects the host_group module module:user This affects the user module labels Aug 23, 2023
@robin-checkmk robin-checkmk linked an issue Aug 23, 2023 that may be closed by this pull request
@robin-checkmk
Copy link
Member

Something feels weird here.
Can you please fork again from devel and just re-apply your changes on top?
Then you can just raise a new PR and copy the description.

@muehlings muehlings closed this Aug 24, 2023
@muehlings muehlings deleted the feature-cme-support branch August 24, 2023 06:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module:host_group This affects the host_group module module:user This affects the user module role:server This affects the server role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEED] Support CME
3 participants