Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align variable names with new standards #463

Merged
merged 32 commits into from
Nov 24, 2023
Merged

Align variable names with new standards #463

merged 32 commits into from
Nov 24, 2023

Conversation

robin-checkmk
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There is no enforced standard for variable names until now.

What is the new behavior?

Inspired by the Ansible best practices, we now enforce proper variable naming through linting now.
We do not entirely follow the best practice, but we are positive that the naming enforced makes sense.
For more details on the new standard, see CONTRIBUTING.md, section Style Guide -> Roles and Playbooks.

Other information

robin-checkmk and others added 15 commits August 15, 2023 13:25
@robin-checkmk robin-checkmk added enhancement New feature or request release:4.0.0 Affects the mentioned release. labels Oct 27, 2023
@robin-checkmk robin-checkmk self-assigned this Oct 27, 2023
@github-actions github-actions bot added the role:agent This affects the agent role label Nov 9, 2023
@github-actions github-actions bot added the module:downtime This affects the downtime module label Nov 10, 2023
@robin-checkmk robin-checkmk marked this pull request as ready for review November 10, 2023 15:43
@robin-checkmk robin-checkmk mentioned this pull request Nov 10, 2023
Merged
7 tasks
@github-actions github-actions bot added module:activation This affects the activation module module:contact_group This affects the contact_group module module:discovery This affects the discovery module module:folder This affects the folder module module:host_group This affects the host_group module module:host This affects the host module module:rule This affects the rule module module:service_group This affects the service_group module module:tag_group This affects the tag_group module module:user This affects the user module module:bakery This affects the bakery module module:timeperiod This affects the timeperiod module module:password labels Nov 24, 2023
@robin-checkmk
Copy link
Member Author

We will fix the failing test in devel.
As this PR is okay in general, we will merge and clean up afterwards.

@robin-checkmk robin-checkmk merged commit d2c3368 into devel Nov 24, 2023
343 of 361 checks passed
@robin-checkmk robin-checkmk deleted the breaking/align-var-naming-rules branch November 24, 2023 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Max-checkmk Max-checkmk Awaiting requested review from Max-checkmk Max-checkmk is a code owner

@lgetwan lgetwan Awaiting requested review from lgetwan lgetwan is a code owner

Assignees

@robin-checkmk robin-checkmk

Labels
enhancement New feature or request module:activation This affects the activation module module:bakery This affects the bakery module module:contact_group This affects the contact_group module module:discovery This affects the discovery module module:downtime This affects the downtime module module:folder This affects the folder module module:host_group This affects the host_group module module:host This affects the host module module:password module:rule This affects the rule module module:service_group This affects the service_group module module:tag_group This affects the tag_group module module:timeperiod This affects the timeperiod module module:user This affects the user module release:4.0.0 Affects the mentioned release. role:agent This affects the agent role
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robin-checkmk