-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added errorhandling to lookup API #475
Merged
robin-checkmk
merged 7 commits into
hackathon/2023-12-01
from
LookupAPI_AddErrorHandling
Dec 1, 2023
Merged
Added errorhandling to lookup API #475
robin-checkmk
merged 7 commits into
hackathon/2023-12-01
from
LookupAPI_AddErrorHandling
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-checkmk
added
enhancement
New feature or request
lookup:version
This affects the lookup module 'version'.
lookup:folder
This affects the lookup module 'folder'.
lookup:folders
This affects the lookup module 'folders'.
lookup:host
This affects the lookup module 'host'.
lookup:hosts
This affects the lookup module 'hosts'.
labels
Nov 13, 2023
Max-checkmk
requested review from
godspeed-you,
lgetwan and
robin-checkmk
as code owners
November 13, 2023 16:04
github-actions
bot
removed
lookup:version
This affects the lookup module 'version'.
lookup:folder
This affects the lookup module 'folder'.
lookup:folders
This affects the lookup module 'folders'.
lookup:host
This affects the lookup module 'host'.
lookup:hosts
This affects the lookup module 'hosts'.
labels
Nov 13, 2023
lgetwan
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate a lot to have a logging mechanism! :-D
Only minor change requests below...
lgetwan
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect, now!
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
What is the new behavior?
Other information
I'm sure there's a nicer way to do this. So any improvements appreciated.
Main problem is that ansible doesn't allow using the ansible.errors library in the api folder, just inside the modules.