Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bakery lookup plugin #478

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Conversation

Max-checkmk
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There is no lookup for the bakingstatus

What is the new behavior?

  • Added a lookup-module for the bakingstatus

Other information

@Max-checkmk Max-checkmk added enhancement New feature or request lookup:bakery This affects the lookup module 'bakery'. labels Nov 22, 2023
@Max-checkmk Max-checkmk self-assigned this Nov 22, 2023
@robin-checkmk robin-checkmk mentioned this pull request Nov 22, 2023
7 tasks
@robin-checkmk
Copy link
Member

Honestly, I do not like the name of the module. Would it be terrible to name it lookup_bakery to be aligned to the actual module?

@Max-checkmk
Copy link
Contributor Author

Honestly, I do not like the name of the module. Would it be terrible to name it lookup_bakery to be aligned to the actual module?

I just took the name of the endpoint, so i don't have any preferences on that.
At least at the moment there is no other endpoint which has something to do with the bakery.

@robin-checkmk
Copy link
Member

Then I would ask you to rename it, if you see no good arguments against it.

lgetwan
lgetwan previously approved these changes Nov 23, 2023
Copy link
Contributor

@lgetwan lgetwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and works well!
Please see my small comment on the "_terms"

plugins/lookup/bakery.py Outdated Show resolved Hide resolved
@robin-checkmk robin-checkmk changed the title Adding bakingstatus lookup Add bakery lookup plugin Nov 24, 2023
@robin-checkmk robin-checkmk added the release:4.0.0 Affects the mentioned release. label Nov 24, 2023
@robin-checkmk robin-checkmk dismissed lgetwan’s stale review December 1, 2023 09:27

Needs a little more work.

@robin-checkmk robin-checkmk changed the base branch from devel to hackathon/2023-12-01 December 1, 2023 15:51
@robin-checkmk robin-checkmk merged commit 13cf1c0 into hackathon/2023-12-01 Dec 1, 2023
25 checks passed
@robin-checkmk robin-checkmk deleted the bakingstatus_lookup branch December 1, 2023 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request lookup:bakery This affects the lookup module 'bakery'. release:4.0.0 Affects the mentioned release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants