Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder lookup module - Update and improve the examples. #607

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Folder lookup module - Update and improve the examples. #607

merged 2 commits into from
Jun 3, 2024

Conversation

lgetwan
Copy link
Contributor

@lgetwan lgetwan commented May 29, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The examples in the module aren't up-to-date.

What is the new behavior?

  • The examples respect the new dictionary structure
  • There's an example on how to query multiple folders, which results in a list of dictionaries.

@lgetwan lgetwan added documentation Improvements or additions to documentation lookup:folder This affects the lookup module 'folder'. labels May 29, 2024
@lgetwan lgetwan self-assigned this May 29, 2024
@lgetwan lgetwan mentioned this pull request May 29, 2024
Merged
7 tasks
robin-checkmk
robin-checkmk requested changes May 29, 2024
View reviewed changes
changelogs/fragments/lookup_folder_examples.yml Outdated Show resolved Hide resolved
plugins/lookup/folder.py Show resolved Hide resolved
robin-checkmk
robin-checkmk approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@robin-checkmk robin-checkmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, ready to merge!

plugins/lookup/folder.py Show resolved Hide resolved
@robin-checkmk robin-checkmk added the release:5.0.0 Affects the mentioned release. label Jun 3, 2024
@robin-checkmk robin-checkmk mentioned this pull request Jun 3, 2024
Merged
7 tasks
@robin-checkmk robin-checkmk merged commit 86f4a0c into devel Jun 3, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robin-checkmk robin-checkmk robin-checkmk approved these changes

Assignees

@lgetwan lgetwan

Labels
documentation Improvements or additions to documentation lookup:folder This affects the lookup module 'folder'. release:5.0.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgetwan @robin-checkmk