Improve idempotency of the registration tasks in the agent #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
….general into feature/agent-improve-idempotency
robin-checkmk
added
role:agent
mueller-ma
reviewed
Jun 12, 2024
…t status codes. This has been fixed.
….general into bugfix/setup-download-status
….general into feature/agent-improve-idempotency
github-actions
bot
added
role:server
…k/ansible-collection-checkmk.general into feature/agent-improve-idempotency
Bugfix setup download status code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Both registrations, agent and updater were carried out by the
agentrole every time causing a change, even if the host was already successfully registered. While this does not break anything (given the configuration is sound), it is an inconvenience.What is the new behavior?
The
agentrole now checks, whether any of the registrations actually need to be performed.Other information
This change should be reviewed carefully, as the approaches chosen might not be ideal, or at least not without risks.
However, the worst case perceivable would be an unnecessary registration, we should not see anything actually break.