Bugfix setup download status code #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t status codes. This has been fixed.
….general into bugfix/setup-download-status
robin-checkmk
merged commit dca1703
into
feature/agent-improve-idempotency
2 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The logic to detect the correct agent download for Windows is broken, due to erroneous usage of the
status_codereturn with theansible.builtin.urimodule.What is the new behavior?
The modules to download web content on Windows (
ansible.windows.win_get_url) and Linux (ansible.builtin.uri) use different return variables for their HTTP status codes.This was confused in
Win32NT-files, as both modules were used, butstatus_codeis only valid foransible.windows.win_get_url. This has been fixed.Other information