Skip to content

Conversation

@Eulex0x
Copy link

@Eulex0x Eulex0x commented Oct 17, 2025

Summary:

The agent_proxmox_ve special agent was crashing whenever backup logs were fetched via fetch_backup_data() due to unhandled errors, causing the entire agent to fail. To fix this, I wrapped the fetch_backup_data() call in a try/except block. Now, if an error occurs (such as API failures or data inconsistencies), the agent logs a warning and continues gracefully by using an empty result for backup logs instead of crashing. This change improves the overall stability and reliability of the agent, ensuring that it still provides other monitoring data even if some backup log retrievals fail. Additionally, the internal logic processes backup logs per VM, so individual VM failures do not affect the entire data set.

Refactor backup data fetching to handle individual nodes and log warnings for failures.
@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days.
Please take a look at the ‘Checks’ section for details on the test results and make the necessary changes.

This pull request will be closed due to inactivity after 60 days, if no action is taken.

@github-actions github-actions bot added the Stale Scheduled for auto-close label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale Scheduled for auto-close

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant