-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bools.xml #113
Open
SantiagoCross
wants to merge
14
commits into
CherishOS:tiramisu-feb
Choose a base branch
from
SantiagoCross:patch-1
base: tiramisu-feb
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update bools.xml #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "SystemUI: Add 14 New VoLTE icon [1/2" This reverts commit 5d5fb3c. Revert "SystemUI: Add Vivo X60 Pro VoLTE Icon [1/2]" This reverts commit d5f1d48. Revert "SystemUI: Add 2 more VoLTE icons [1/2]" This reverts commit b70a590. Revert "SystemUI: Perform soft reboot when enabling combined signal icons" This reverts commit 27d3ee9. Revert "SystemUI: Make combined signal icons configurable at runtime [1/2]" This reverts commit 52448e5. Revert "fixup:Revert "Revert^2 "Remove support for COMBINED_SIGNAL_ICONS""" This reverts commit 403155b. Revert "Forward Port Volte changes to a13" This reverts commit a31b905. Revert "Override VoLTE icon with VoWiFi when available [1/2]" This reverts commit 9409945. Revert "SystemUI: Add more VoWiFi icon styles [1/2]" This reverts commit 470c21f. Revert "SystemUI: support VoWIFI icons" This reverts commit 3593b4e. Revert "Option to Display Data Disabled Indicator Icon [1/2]" This reverts commit 9a2643b. Signed-off-by: Hưng Phan <[email protected]> Revert "Allow using 4G icon instead LTE [1/2]" This reverts commit 81e2a8b. Signed-off-by: Hưng Phan <[email protected]> Revert "Make roaming indicator optional [1/2]" This reverts commit ae66c94. Signed-off-by: Hưng Phan <[email protected]> Revert "Add option to select VoLTE icon [1/2]" This reverts commit dcab349. Signed-off-by: Hưng Phan <[email protected]> Revert "SystemUI: Use our default VoLTE icon" This reverts commit 861612a. Revert "SystemUI: old style mobile indicator layout fixes" This reverts commit a8ed696. Revert "SystemUI: status bar mobile indicator - code sharing is caring" This reverts commit d2ab268. Revert "SystemUI: old style mobile data indicators [1/2]" This reverts commit fa8f6c5. Signed-off-by: Hưng Phan <[email protected]> Revert "SystemUI: Add support for displaying Volte icon [SQUASH]" This reverts commit 3212a0c. Revert "[QSUASH]Cleanup some changes for volte and mobile data" This reverts commit 03aad9c. Revert "SystemUI: Improve statusbar mobile type icons padding" This reverts commit 0372d95. Revert "[SQUASH] SystemUI: Add support for displaying Volte and VoWifi icons" This reverts commit 0a738fb. Signed-off-by: Hưng Phan <[email protected]> SystemUI: Fix suspicious spaces around mobile icons When dual SIM is in use, I could observe random but suspicious spaces around mobile signal icons. This could happened especially after expanding and collapsing the QS panel. This is caused by unmatched size between StatusBarMobileView and its only child. More debugging deepening into the sdk is needed for me to find out the real reason. I'm lazy, so let's bind the measurement to its only child for a quick fix. Change-Id: Id6b4e38b31a9de5061ac332d319d313ecf11c177 Signed-off-by: LibXZR <[email protected]> Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: Hưng Phan <[email protected]> SystemUI: old style mobile indicator layout fixes Change-Id: Iad2f8cf5195ad966a21002f9145389b7348ffbda Signed-off-by: Hưng Phan <[email protected]>
This reverts commit 9273f91. Change-Id: If0c47bc229eb9d6b4d9257670a2ff356c5f96368 Signed-off-by: Jason Edson <[email protected]> Signed-off-by: Sipun Ku Mahanta <[email protected]> Signed-off-by: Hưng Phan <[email protected]>
This reverts commit b9ee59b.
@/neobuddy89: Clean up unrequired derps. Adapted for A13 QPR1. Co-authored-by: Adithya R <[email protected]> Co-authored-by: Jyotiraditya Panda <[email protected]> Co-authored-by: Pranav Vashi <[email protected]> Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: Hưng Phan <[email protected]>
Change-Id: I6c9e202a9e6e0d2c0a06edd887c44cb51c5853f4 Signed-off-by: Sipun Ku Mahanta <[email protected]> Signed-off-by: Hưng Phan <[email protected]>
Change-Id: I7cc958058373ea63cac07aac9c6f027d89594c48 Co-authored-by: Alex Yustasov <[email protected]> Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: Sipun Ku Mahanta <[email protected]> Signed-off-by: Hưng Phan <[email protected]>
Change-Id: I126d469e741f5e5ed52ab72429685915b46e8819 Signed-off-by: Sipun Ku Mahanta <[email protected]> Signed-off-by: Hưng Phan <[email protected]>
01-04 23:29:06.884 1903 1903 E AndroidRuntime: java.util.ConcurrentModificationException 01-04 23:29:06.884 1903 1903 E AndroidRuntime: at java.util.ArrayList$Itr.next(ArrayList.java:860) 01-04 23:29:06.884 1903 1903 E AndroidRuntime: at com.android.systemui.statusbar.phone.StatusBarIconControllerImpl.addIconGroup(StatusBarIconControllerImpl.java:96) ... Change-Id: I52f03771c1acc060f08989e96dbb7c64b0ceec57 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: Sipun Ku Mahanta <[email protected]> Signed-off-by: Hưng Phan <[email protected]>
Change-Id: Idc1806d580e49f3e83f698e967df59a1c4f71a4e Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: Sipun Ku Mahanta <[email protected]> Signed-off-by: Hưng Phan <[email protected]>
Change-Id: Ifba4634ced97d9c1c4d0a405ecd896641dc32986 Signed-off-by: SuperDroidBond <[email protected]> Signed-off-by: Sipun Ku Mahanta <[email protected]> Signed-off-by: Hưng Phan <[email protected]>
The new "Silk design" mobile icons introduced in [1] have 2dp of spacing inside it on each sides. This is quite unnecessary and looks ugly as the mobile layout already provides 2.5dp of padding. For the sake of consistency, remove this spacing using insets and rely only on padding. Add space only for the second SIM's mobile data type icon. While we're at it, always use 4G icon instead of LTE to reduce space usage. [1]: 084c13c ("Update RAT icons to match Silk design") Change-Id: I4d703e37983ee45da2219936156028d5d40f31a0 Signed-off-by: Hưng Phan <[email protected]>
The Material You design mobile type icons are just text such as "3G" "4G+" "5G" in Google Sans font, as such it makes sense to scale it with system font size, and it looks more consistent with battery percentage text. Change-Id: I2e3a985a82c2b9c99a6ceeb5b7eb2110d9bc2038 Signed-off-by: Hưng Phan <[email protected]>
Revert "SystemUI: BcSmartspaceView: Allow setting current page" This reverts commit ef780fc39ba5e87d14194afa8cd3e38015cb5601. Revert "Smartspace: Fix music indication not showing on doze/aod" This reverts commit a24ebfdc143bd286c1b6294832741696627c1e2e. Revert "SystemUI: Forward-port smartspace to Android 13" This reverts commit ca6ab57a5e00fcb8eddc1fa09d073222fd55e387. Revert "SystemUI: Implement Reverse-engineered Smartspace" This reverts commit 00049515057082e03de0856eee21d8d4154d981c. Signed-off-by: Hưng Phan <[email protected]>
Enabled burn in protection in status bar
hungphan2001
force-pushed
the
tiramisu
branch
4 times, most recently
from
February 10, 2023 12:49
26bf274
to
ffd748a
Compare
hungphan2001
force-pushed
the
tiramisu
branch
from
February 19, 2023 14:03
2164710
to
243ed53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled burn in protection in status bar