Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hotfix test pr #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: hotfix test pr #11

wants to merge 1 commit into from

Conversation

Chethan-rao
Copy link
Owner

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add validate_psync_reference_id implementation for Noon as we can make a Psync using connector_request_reference_id and currently core is defaulting if connector_transaction_id is not present it fails the Psync.
Main PR: juspay/hyperswitch#2886

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cant be reproduced in envs as either a timeout is required or would need to delete the connector_transaction_id in the DB.

Check for regular proper working of Psyncs in all the cases.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao force-pushed the master branch 5 times, most recently from c59442b to a4ee9a4 Compare November 24, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant