CHIA-1862 Fix FullNodeAPI's request_block_headers returned filter #18923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
Changed
AmineKhaldi
force-pushed
the
fix_simplify_request_block_headers
branch
from
4c3c008 to
2c8e2fc
Compare
Pull Request Test Coverage Report for Build 12032420319Details
💛 - Coveralls |
AmineKhaldi
commented
Nov 25, 2024
arvidn
reviewed
Nov 26, 2024
AmineKhaldi
force-pushed
the
fix_simplify_request_block_headers
branch
2 times, most recently
from
032dd93 to
9195013
Compare
|
your benchmark doesn't show that it's safe to remove the serialization optimization. |
AmineKhaldi
force-pushed
the
fix_simplify_request_block_headers
branch
from
9195013 to
41f24e2
Compare
AmineKhaldi
changed the title
arvidn
reviewed
Dec 6, 2024
| # We're at the transactions_info optional. | ||
| # If it's not None, consider this a transaction block. | ||
| is_tx_block = buf[0] != 0 | ||
| return height, is_tx_block |
There was a problem hiding this comment.
as far as I can tell, this function is only tested by your new test, in which case the block is a transaction block. I think it would be good to have a thorough test of this function as well. I think there is a test already you could just add this function to
|
looks good! It would be good to have proper test coverage of the new parsing function too |
AmineKhaldi
force-pushed
the
fix_simplify_request_block_headers
branch
from
41f24e2 to
6b2db3a
Compare
Done. Please note that while the test in question is skipped in main, enabling it and running it (with this extra coverage added to it) passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This fixes a bug where
request_block_headersis not accounting for removals and additions when computing the transactions filter.Current Behavior:
request_block_headersdoesn't account for removals and additions in transactions filter computation.New Behavior:
request_block_headerstakes them properly into account.