Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix greek login screen footer elements wrap (M2-8099) #895

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

andrevitalb
Copy link
Member

📝 Description

🔗 Jira Ticket M2-8099

A change to the footer's styling was added, so that in case a longer text or more items are added to the footer, the overflow/hiding problem won't be present.

This change won't be noticeable from previous instances for now, since the elements as they are right now don't present that issue:

image

Changes include:

  • Updated styling for footer container (inside LoginScreen.tsx)

📸 Screenshots

Before (Optional) After
image image

NOTE: The change won't be noticeable due to the current text for the three footer elements being different.

🪤 Peer Testing

In project's current state, error can't be reproduced, so there's no validation required.

@felipeMetaLab
Copy link
Contributor

Looks good, but I am wondering, this change has to be applied for all languages or only greek ?

@andrevitalb
Copy link
Member Author

@felipeMetaLab Ideally, all languages would be good with this change. In the event of, let's say a fourth item is added to the footer, or the current texts are updated to something a bit longer, this change would be needed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants