fix: Update dependencies with high alerts (M2-7990) #550
+1,283
−1,545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d versions and lint newest required fixes (M2-7990)
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ramirlm
changed the title
ChaconC
reviewed
Nov 14, 2024
| import { Banner, BannerProps } from '../Banner'; | ||
| import { SUCCESS_BANNER_DURATION } from './lib/const'; |
There was a problem hiding this comment.
This is causing an error:
2:1 error `./lib/const` import should occur before import of `../Banner` import/order
ChaconC
reviewed
Nov 14, 2024
| import { Answer, hasAdditionalResponse, requiresAdditionalResponse } from '../lib'; | ||
| import { ItemPicker } from './items/ItemPicker'; |
There was a problem hiding this comment.
Same here
./items/ItemPicker` import should occur before import of `../lib`
ChaconC
reviewed
Nov 14, 2024
| @@ -95,7 +95,7 @@ export const SurveyWidget = (props: Props) => { | |||
| publicAppletKey={publicAppletKey} | |||
| appletId={appletId} | |||
| errorLabel={ | |||
| publicAppletKey ? t('additional.invalid_public_url') : error?.evaluatedMessage ?? '' | |||
| publicAppletKey ? t('additional.invalid_public_url') : (error?.evaluatedMessage ?? '') | |||
There was a problem hiding this comment.
I'm also seeing a prettier error here but prettier:fix changes it back 🤷
There was a problem hiding this comment.
Investigating @ChaconC 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates required and possible libraries to the minimum required versions, as well as consequent lit/prettier tweaks.
🔗 Jira Ticket M2-7990
Changes include:
axiosandjsdomdependencies🪤 Peer Testing
axiospackage, all that is necessary is to test if requests are being sent and received correctlyvitestand the tests passing indicates everything is working well