Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HotChocolate.Templates.Server #6834

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jan 17, 2024

Summary of the changes (Less than 80 chars)

  • Deleted templates/Server directory.
  • Updated build configuration.
  • Updated v12 & v13 docs.

Closes #5846


@michaelstaib Can you deprecate the package on NuGet?

@github-actions github-actions bot added 📚 documentation This issue is about working on our documentation. 🧰 maintenance labels Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (584b932) 70.89% compared to head (10d7c79) 73.69%.
Report is 3 commits behind head on main.

Files Patch % Lines
...tCore/Extensions/EndpointRouteBuilderExtensions.cs 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6834      +/-   ##
==========================================
+ Coverage   70.89%   73.69%   +2.80%     
==========================================
  Files        2520     2534      +14     
  Lines      126678   127322     +644     
==========================================
+ Hits        89805    93836    +4031     
+ Misses      36873    33486    -3387     
Flag Coverage Δ
unittests 73.69% <88.88%> (+2.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 5278d90 into ChilliCream:main Jan 21, 2024
4 of 5 checks passed
@glen-84 glen-84 deleted the issue-5846 branch January 22, 2024 08:06
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation. 🧰 maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Conflicting dotnet new templates
2 participants