Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @include/@skip for non-nullable fields #7918

Conversation

timward60
Copy link
Contributor

@timward60 timward60 commented Jan 9, 2025

Summary of the changes (Less than 80 chars)

  • Adds integration test showing usage of @include/@skip directives on non-nullable field types.
  • Updates the code generation to not treat field as non-nullable when these directives are present.

Closes #7917

@timward60 timward60 force-pushed the timward/include-directive-non-nullable-type branch from a6799d2 to 6fa0a41 Compare January 9, 2025 09:08
@michaelstaib
Copy link
Member

@timward60 sorry for the wait, this so coming with 14.4 sometime next week.

@michaelstaib michaelstaib merged commit 3019599 into ChilliCream:main Jan 22, 2025
3 checks passed
@michaelstaib michaelstaib added 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 📢 announce Consider announcing on Slack. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📢 announce Consider announcing on Slack. 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate 🌶️ strawberry shake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@include/@skip for non-nullable fields should support nullable values
2 participants